-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: removes debug in migrate #342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use commitlint for linting commit messages. Use git cz
for an interactive commit or use one of these.
@anu-007 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @dhruvdutt Please review the new changes. |
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
devtool: 'eval', | ||
entry: [ | ||
devtool: 'eval', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please keep the 'no space' between the two lines, please? I guess this wasn't intentional :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, unless jest did it?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a file generated by Jest, __snapshots__
folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's why we run prettier on the config after we've written @ematipico . j.literal
and j.identifier
causes this, no bug.
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What kind of change does this PR introduce?
bugfix - removes
debug
inmigrate
.Did you add tests for your changes?
No
If relevant, did you update the documentation?
n/a
Summary
Fixes 120 : removes
debug
after runningmigrate
on a config that has debugDoes this PR introduce a breaking change?
No
Other information
n/a